Change in vdsm[master]: Added standard build skeleton

dcaroest at redhat.com dcaroest at redhat.com
Mon Jun 8 18:23:54 UTC 2015


David Caro has posted comments on this change.

Change subject: Added standard build skeleton
......................................................................


Patch Set 2:

(3 comments)

I think you misunderstood my part here, I'm not going to tell you what to test and how to test it, I'm not going to write the tests, I can give you support and a platform to do it, but it's up to you (project devels) to test whatever you want however you want to test it and maintain those tests.

You decide if you want to use pytest, make, autotools, doctest, pep8, pylint, bats or anything else, and you decide what is required to pass to get a patch merged, mainly because you are the ones that know how the product works and have the knowledge to decide which tool/methodology is more appropriate for the project.

https://gerrit.ovirt.org/#/c/41928/2/automation/build-artifacts.sh
File automation/build-artifacts.sh:

Line 1: #!/usr/bin/env bash
Line 2: #
Line 3: # Build the artifacts that are going to be archived, they will go under
Line 4: # $repo_root/exported-artifacts directory
> What is repo_root? is this an environment variable?
no, it's the git repository root directory, when this script runs it will be $PWD
Line 5: #
Line 6: 


https://gerrit.ovirt.org/#/c/41928/2/automation/check-merged.sh
File automation/check-merged.sh:

Line 2: #
Line 3: # Executed on each merge, should be considered as the gate for the change to
Line 4: # get merged, if not working no changes will get merged
Line 5: 
Line 6: echo "TODO"
> We need at least the implementation that keeps the current behavior.
which test/tests you want to keep it's behavior from? there are quite a few with totally different configuration and requirements


https://gerrit.ovirt.org/#/c/41928/2/automation/check-patch.sh
File automation/check-patch.sh:

Line 2: #
Line 3: # Run on each patch to gerrit, should be faster than check-meged and require
Line 4: # less resources but thorough enough to provide relevant feedback
Line 5: 
Line 6: echo "TODO"
> We need at least the implementation that keeps the current behavior.
idem as the previous shell script


-- 
To view, visit https://gerrit.ovirt.org/41928
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24b446d3ae38c944b5a28d56ed0965d0f2edc206
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list