Change in vdsm[master]: Add support for KSM and CpuTune calls to XMLRPC for MOM to use

alitke at redhat.com alitke at redhat.com
Mon Jun 8 14:51:39 UTC 2015


Adam Litke has posted comments on this change.

Change subject: Add support for KSM and CpuTune calls to XMLRPC for MOM to use
......................................................................


Patch Set 5:

(1 comment)

small schema nit.  Otherwise looks good.

https://gerrit.ovirt.org/#/c/41571/5/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 544: #
Line 545: # Since: 4.17.0
Line 546: ##
Line 547: {'type': 'KsmTuneParams',
Line 548:  'data': {'run': 'int', 'sleep_millisecs': 'str', 'pages_to_scan': 'str'}}
these are all integers, no?  Ignore xmlrpc issues here.  This is a new API.
Line 549: 
Line 550: ##
Line 551: # @Host.setKsmTune:
Line 552: #


-- 
To view, visit https://gerrit.ovirt.org/41571
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd318b50abf8605c2584cb3b5316e2ca2ac4f5ef
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list