Change in vdsm[master]: hooks: virt: add support for memory hotplug

danken at redhat.com danken at redhat.com
Sun Jun 7 14:53:03 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: hooks: virt: add support for memory hotplug
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40548/2/vdsm/hooks.py
File vdsm/hooks.py:

Line 322:     return _runHooksDir(None, 'after_set_num_of_cpus', vmconf=vmconf,
Line 323:                         params=params, raiseError=False)
Line 324: 
Line 325: 
Line 326: def before_memory_hotplug(domxml, vmconf={}, params={}):
> the hooks are called on the next patch, where support to hotplug mem is add
unlike hot_hot_plug_nic, this hook does not have anything with xml that is being plugged, or is it?

It makes more sense to add the hookpoint after you already have the code where it is to be used - at lease I find it hard to understand what would be passed as the domxml.
Line 327:     return _runHooksDir(domxml, 'before_memory_hotplug', vmconf=vmconf,
Line 328:                         params=params)
Line 329: 
Line 330: 


-- 
To view, visit https://gerrit.ovirt.org/40548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I152e2dd0dfacadb703889fa8e909cf060731eb4f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list