Change in vdsm[master]: net: bondingOptions should not be a part of runningConfig ne...

ibarkan at redhat.com ibarkan at redhat.com
Sun Jun 7 12:22:16 UTC 2015


Ido Barkan has uploaded a new change for review.

Change subject: net: bondingOptions should not be a part of runningConfig networks
......................................................................

net: bondingOptions should not be a part of runningConfig networks

Since all attributes of _addNetwork are copied as a flat dictionary
to running Config during _alterRunningConfig decorator,
bondingOptions mistakenly found their way into runningConfig, and
then into PersisstentConfig, as if they were part of the network
attributes dictionary during the call.

Change-Id: I374239670df77804e397b4189a9405f1479d0259
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
---
M lib/vdsm/netconfpersistence.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/42021/1

diff --git a/lib/vdsm/netconfpersistence.py b/lib/vdsm/netconfpersistence.py
index 26534eb..7924a1e 100644
--- a/lib/vdsm/netconfpersistence.py
+++ b/lib/vdsm/netconfpersistence.py
@@ -46,7 +46,7 @@
         cleanAttrs = dict((key, value) for key, value in attributes.iteritems()
                           if value is not None and key not in
                           ('configurator', '_netinfo', 'force',
-                           'implicitBonding'))
+                           'bondingOptions', 'implicitBonding'))
         self.networks[network] = cleanAttrs
         logging.info('Adding network %s(%s)', network, cleanAttrs)
 


-- 
To view, visit https://gerrit.ovirt.org/42021
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I374239670df77804e397b4189a9405f1479d0259
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>


More information about the vdsm-patches mailing list