Change in vdsm[master]: tcTest: skip tests if somehow same bridge name is reused

ibarkan at redhat.com ibarkan at redhat.com
Sun Jun 7 11:30:04 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: tcTest: skip tests if somehow same bridge name is reused
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/41898/2/tests/tcTests.py
File tests/tcTests.py:

Line 83:         except RuntimeError as e:
Line 84:             if "can't create bridge with the same name" in e.message:
Line 85:                 raise SkipTest(e.message)
Line 86:             else:
Line 87:                 raise
> Why not use @brokentest on the test calling this?
+1
Line 88: 
Line 89:         # learning interval is different on different kernels, so set it
Line 90:         # explicit for 2.x kernels
Line 91:         if os.uname()[2].startswith("2"):


-- 
To view, visit https://gerrit.ovirt.org/41898
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id678882d68976618360bcce76f16837d67e274ea
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list