Change in vdsm[master]: serial console: add code to prepare the path

fromani at redhat.com fromani at redhat.com
Fri Jun 5 16:04:59 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: serial console: add code to prepare the path
......................................................................


Patch Set 5: Verified+1

Verified together: 41896, 40704

this patch needs polishing (and suggestion about how to do that :))

vmconsole.py should probably renamed and moved under virt/ (not 100% sure, however).

But it works, console was succesfully bound by ovirt-vmconsole-host

ovirt-v+ 23441  0.4  0.0  87132  3964 ?        Ss   17:54   0:00  \_ sshd: ovirt-vmconsole [priv]
ovirt-v+ 23443  0.0  0.0  87132  1604 ?        S    17:54   0:00      \_ sshd: ovirt-vmconsole at pts/1
ovirt-v+ 23444  0.1  0.0  47072  2188 pts/1    Ss+  17:54   0:00          \_ /usr/bin/socat -,raw,echo=0 UNIX-CONNECT:/var/run/ovirt-vmconsole-console/e1c7230e-4058-4fda-8d03-5d4d2ac29f54.sock

-- 
To view, visit https://gerrit.ovirt.org/41896
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f851d7f7233265d33896b3aad5604e84c8af53b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list