Change in vdsm[master]: virt: Memory hotunplug

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Fri Jun 5 09:59:11 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: virt: Memory hotunplug
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/41291/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2213:         for dev in self.conf['devices'][:]:
Line 2214:             if (dev['type'] == hwclass.MEMORY and
Line 2215:                         dev['size'] == memParams['size']):
Line 2216:                 with self._confLock:
Line 2217:                     self.conf['devices'].remove(dev)
I wonder if we can actually remove the device already. We only sent a request to unplug and the guest may or may not let go of that device. Anytime in the future. I believe (same as in hotplug) we have to leave it as is and depend on async change in devices to recognize the actual unplug
Line 2218:                 memDev = dev
Line 2219:                 break
Line 2220: 
Line 2221:         self.saveState()


-- 
To view, visit https://gerrit.ovirt.org/41291
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09c878711b9015129f525970f6cc1f11f89998b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list