Change in vdsm[master]: jsonrpc: ignore not needed transport
danken at redhat.com
danken at redhat.com
Thu Jun 4 13:47:09 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: ignore not needed transport
......................................................................
Patch Set 16: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40173/16/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 359: else:
Line 360: return ("result" in obj or "error" in obj)
Line 361:
Line 362: def _handleMessage(self, req):
Line 363: message = req[1]
I personally like the self-documenting code, which reminds the reader what req is made of. I see there is no grand support for it from neither. Let's abandon this change for now.
Line 364: try:
Line 365: mobj = json.loads(message)
Line 366: isResponse = self._isResponse(mobj)
Line 367: except:
--
To view, visit https://gerrit.ovirt.org/40173
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icecf5c06e216151bd95f56f6fef9ed9ccba9074d
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list