Change in vdsm[master]: hostdev: destroy VM with hostdev even without IOMMU support

fromani at redhat.com fromani at redhat.com
Thu Jun 4 12:25:49 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: hostdev: destroy VM with hostdev even without IOMMU support
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/41886/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1789:         if not self.recovering:
Line 1790:             for dev in self._devices[hwclass.HOSTDEV]:
Line 1791:                 self.log.debug('Detaching device %s from the host.' %
Line 1792:                                dev.device)
Line 1793:                 dev.detach()
> Ok, I'm still confused. Can you please explain again why we don't need anym
We had it in v2
Line 1794: 
Line 1795:             if initDomain:
Line 1796:                 domxml = hooks.before_vm_start(self._buildDomainXML(),
Line 1797:                                                self.conf)


-- 
To view, visit https://gerrit.ovirt.org/41886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I857ec18c0932de247469f6fb780d1b28aa3873e8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list