Change in vdsm[master]: hostdev: raise more meaningful exception without iommu support

danken at redhat.com danken at redhat.com
Thu Jun 4 11:55:06 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: hostdev: raise more meaningful exception without iommu support
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/41885/3/vdsm/hostdev.py
File vdsm/hostdev.py:

Line 176: 
Line 177:     if CAPABILITY_TO_XML_ATTR[device_params['capability']] == 'pci':
Line 178:         try:
Line 179:             iommu_group = device_params['iommu_group']
Line 180:         except:
again, please do not use this idiom. Catch only the excepion you expect (KeyError)
Line 181:             raise NoIOMMUSupportException('hostdev passthrough without iommu')
Line 182:         supervdsm.getProxy().appropriateIommuGroup(iommu_group)
Line 183:         libvirt_device.detachFlags(None)
Line 184: 


-- 
To view, visit https://gerrit.ovirt.org/41885
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I084b34876be937ed2022ca321c9584228344b3bb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list