Change in vdsm[master]: hostdev: raise more meaningful exception without iommu support

mpolednik at redhat.com mpolednik at redhat.com
Thu Jun 4 11:31:22 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: hostdev: raise more meaningful exception without iommu support
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/41885/2/vdsm/hostdev.py
File vdsm/hostdev.py:

Line 28:                           'scsi': 'scsi',
Line 29:                           'usb_device': 'usb'}
Line 30: 
Line 31: class NoIOMMUSupportException(Exception):
Line 32:     pass
> a docstring can replace "pass" here, and can be friendlier. 
since I'm already doing jenkins spam, will think about it
Line 33: 
Line 34: 
Line 35: def _name_to_pci_path(device_name):
Line 36:     return device_name[4:].replace('_', '.').replace('.', ':', 2)


-- 
To view, visit https://gerrit.ovirt.org/41885
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I084b34876be937ed2022ca321c9584228344b3bb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list