Change in vdsm[master]: hostdev: destroy VM with hostdev even without IOMMU support

fromani at redhat.com fromani at redhat.com
Thu Jun 4 10:52:15 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: hostdev: destroy VM with hostdev even without IOMMU support
......................................................................


Patch Set 2: Code-Review+1

looks ok.

Few random comments, feel free to discard or implement in later patches.

Here may make sense to translate internal KeyError into something more revealing (MissingDevice? UnknownDevice?)

-- 
To view, visit https://gerrit.ovirt.org/41886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I857ec18c0932de247469f6fb780d1b28aa3873e8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list