Change in vdsm[master]: reactor: move creation to clientIF

danken at redhat.com danken at redhat.com
Wed Jun 3 17:24:20 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: reactor: move creation to clientIF
......................................................................


reactor: move creation to clientIF

It is final step performed in several patches to have single class
responsible for processing i/o loop. Overall goal in number of changes
was to simplify the code and have single responsibility per class. It
was not the case with Protocoldetector and StompReactor before.

Change-Id: I8f36ec36b91fcc46e1ab46eb92f9739e9e19e448
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: https://gerrit.ovirt.org/40170
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Yeela Kaplan <ykaplan at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/jsonRpcHelper.py
M tests/protocoldetectorTests.py
M vdsm/clientIF.py
M vdsm/protocoldetector.py
4 files changed, 23 insertions(+), 16 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yeela Kaplan: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/40170
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8f36ec36b91fcc46e1ab46eb92f9739e9e19e448
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list