Change in vdsm[master]: tcTest: skip tests if somehow same bridge name is reused

Federico Simoncelli fsimonce at redhat.com
Wed Jun 3 14:40:10 UTC 2015


Federico Simoncelli has posted comments on this change.

Change subject: tcTest: skip tests if somehow same bridge name is reused
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/41898/1/tests/tcTests.py
File tests/tcTests.py:

Line 80:     def addDevice(self):
Line 81:         try:
Line 82:             check_call([EXT_BRCTL, 'addbr', self.devName])
Line 83:         except RuntimeError as e:
Line 84:             if 'can\'t create bridge with the same name' in e.message:
As rule of thumb I decided that I like to do what python repr would do with strings:


    print(repr("hello world"))
    'hello world'

    print(repr("hello world'"))
    "hello world'"


So in this case I think it'd prefer double-quotes over single-quotes and the escape for the apostrophe.
Line 85:                 raise SkipTest(e.message)
Line 86:             else:
Line 87:                 raise
Line 88: 


-- 
To view, visit https://gerrit.ovirt.org/41898
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id678882d68976618360bcce76f16837d67e274ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list