Change in vdsm[master]: chmod for spmprotect.sh script is not needed and expose an e...

ybronhei at redhat.com ybronhei at redhat.com
Wed Jun 3 13:30:02 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: chmod for spmprotect.sh script is not needed and expose an error
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/41883/1/configure.ac
File configure.ac:

Line 423: ])
Line 424: 
Line 425: AC_OUTPUT([
Line 426:     tests/run_tests.sh
Line 427:     tests/run_tests_local.sh
> But don't you need to make sure that `configure` generats the .sh file our 
I don't know, but it works great as is.
Line 428: ],[
Line 429:     chmod +x tests/run_tests.sh
Line 430:     chmod +x tests/run_tests_local.sh
Line 431: ])


-- 
To view, visit https://gerrit.ovirt.org/41883
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0815728e876b33361ec1124a5c82b130e9b8ba2c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list