Change in vdsm[master]: events: vm status notifications

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Wed Jun 3 08:40:49 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: events: vm status notifications
......................................................................


Patch Set 21:

(1 comment)

https://gerrit.ovirt.org/#/c/38937/21/tests/vmfakelib.py
File tests/vmfakelib.py:

Line 57:         self.channelListener = None
Line 58:         self.vmContainerLock = threading.Lock()
Line 59:         self.vmContainer = {}
Line 60: 
Line 61:     def notify(self, event_id, **kwargs):
> why do we need this?
We need it for the tests to pass. There is bunch of tests which check status 'Down' with different params. During this tests there is attempt to send an event so we need to ignore it.
Line 62:         pass
Line 63: 
Line 64: 
Line 65: class Domain(object):


-- 
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list