Change in vdsm[master]: stomp: outgoing connection to a broker

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Wed Jun 3 07:50:37 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: stomp: outgoing connection to a broker
......................................................................


Patch Set 24:

(1 comment)

https://gerrit.ovirt.org/#/c/38819/24/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 345:         self._reactor.wakeup()
Line 346:         return sub
Line 347: 
Line 348:     def send(self, message, destination=stomp.LEGACY_SUBSCRIPTION_ID_RESPONSE,
Line 349:              headers=None):
> why didn't you do it where you added this default to StompServer?
Done
Line 350:         self.log.debug("Sending request")
Line 351:         self._aclient.send(
Line 352:             destination,
Line 353:             message,


-- 
To view, visit https://gerrit.ovirt.org/38819
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied3095a305fd5a5bfc19c8bc0342fba7cb811843
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list