Change in vdsm[master]: events: vm status notifications

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Wed Jun 3 07:46:46 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: events: vm status notifications
......................................................................


Patch Set 21:

(2 comments)

https://gerrit.ovirt.org/#/c/38937/21/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 303:         elif 'restoreState' in self.conf:
Line 304:             self._lastStatus = vmstatus.RESTORING_STATE
Line 305:         else:
Line 306:             self._lastStatus = vmstatus.WAIT_FOR_LAUNCH
Line 307:         self._evaluatedStatus = None
> lastStatus?
It is evaluatedStatus. We need to know previous status.
Line 308:         self._migrationSourceThread = migration.SourceThread(self)
Line 309:         self._kvmEnable = self.conf.get('kvmEnable', 'true')
Line 310:         self._guestSocketFile = constants.P_VDSM_RUN + self.conf['vmId'] + \
Line 311:             '.guest.socket'


Line 378:             if self._lastStatus != value:
Line 379:                 self.saveState()
Line 380:                 self._lastStatus = value
Line 381: 
Line 382:     def send_status_event(self):
> it doesn't always send event. it should be called - poll_event_status and y
there is no pooling here. I agree that it do not send the status always because it do not make sense to send it when it was not changed.
Line 383:         vm_status = self._getVmStatus()['status']
Line 384:         if vm_status != self._evaluatedStatus:
Line 385:             self._evaluatedStatus = vm_status
Line 386:             stats = {


-- 
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list