Change in vdsm[master]: sslutils: move createSSLContext from clientIF

ybronhei at redhat.com ybronhei at redhat.com
Wed Jun 3 07:45:57 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: sslutils: move createSSLContext from clientIF
......................................................................


Patch Set 12: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/36699/12/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:

Line 342: def ssl_enabled():
Line 343:     return config.getboolean('vars', 'ssl')
Line 344: 
Line 345: 
Line 346: def create_ssl_context():
you always use the same files? I would send all the parameters as function parameters and have the below values as defaults.. but not sure if its really needed
Line 347:     if ssl_enabled():
Line 348:         truststore_path = config.get('vars', 'trust_store_path')
Line 349:         key_file = os.path.join(truststore_path, 'keys', 'vdsmkey.pem')
Line 350:         cert_file = os.path.join(truststore_path, 'certs', 'vdsmcert.pem')


-- 
To view, visit https://gerrit.ovirt.org/36699
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Bronheim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list