Change in vdsm[master]: network: Recognize macvlans as fake devices

fabiand at redhat.com fabiand at redhat.com
Tue Jun 2 12:32:30 UTC 2015


Fabian Deutsch has posted comments on this change.

Change subject: network: Recognize macvlans as fake devices
......................................................................


Patch Set 1:

(1 comment)

The motivation is to let vdsm use macvlan nics inside a container, where real nics are not always visible.

https://gerrit.ovirt.org/#/c/40608/1/lib/vdsm/ipwrapper.py
File lib/vdsm/ipwrapper.py:

Line 219:         """
Line 220:         Returns True iff vdsm config marks the DUMMY or VETH dev to be reported
Line 221:         as NIC.
Line 222:         """
Line 223:         if self.isDUMMY() or self.isVETH() or self.isMACVLAN():
> please note that macvlans are used by libvirt to connect VMs to VFs (used b
Right, that is a good hint.
It then seems that it should not be enabled by default to also recognice macvlans as nics.
Maybe this makese sense when we see that vdsm is run in a container.
Line 224:             return anyFnmatch(self.name, self._fakeNics)
Line 225:         return False
Line 226: 
Line 227:     def isNICLike(self):


-- 
To view, visit https://gerrit.ovirt.org/40608
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list