Change in vdsm[master]: net: bonding: validate options based on pre-dumped ones

danken at redhat.com danken at redhat.com
Mon Jun 1 11:56:34 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: bonding: validate options based on pre-dumped ones
......................................................................


net: bonding: validate options based on pre-dumped ones

The removed code created a bond device only to check if the provided
options are recongnized by the kernel. This was buggy, as the options
depends on the bonding mode. It was also redundant, as we already depend
on pre-dumped maps of bond options per bond mode, so we can (and should)
use it here, too.

Change-Id: I03fce903280d5eda817e713a51c8079dab9d7649
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/41616
Continuous-Integration: Jenkins CI
Reviewed-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-by: Petr Horáček <phoracek at redhat.com>
---
M lib/vdsm/netinfo.py
M tests/netmodelsTests.py
M vdsm/network/api.py
M vdsm/network/models.py
4 files changed, 38 insertions(+), 47 deletions(-)

Approvals:
  Ondřej Svoboda: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/41616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I03fce903280d5eda817e713a51c8079dab9d7649
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list