Change in vdsm[master]: periodic: make VmDispatcher ignore TooManyTasks

fromani at redhat.com fromani at redhat.com
Mon Jun 1 07:44:30 UTC 2015


Francesco Romani has uploaded a new change for review.

Change subject: periodic: make VmDispatcher ignore TooManyTasks
......................................................................

periodic: make VmDispatcher ignore TooManyTasks

VmDispatcher is meant to make N independent operations
from on (VM bulk sampling), being N the number of active VMs.

To fullfill this claim, we ignore TooManyTasks in the
vm dispatching loop, even though is highly likely that
once one TooManyTasks error is encountered, many subsequent
dispatch() attempt will fail.

Change-Id: Iad2d186327f8607aaeb41ca132a9a8a0806869cf
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/periodic.py
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/41657/1

diff --git a/vdsm/virt/periodic.py b/vdsm/virt/periodic.py
index acfe2f6..f226424 100644
--- a/vdsm/virt/periodic.py
+++ b/vdsm/virt/periodic.py
@@ -223,6 +223,7 @@
     def __call__(self):
         vms = self._get_vms()
         skipped = []
+        op = None
 
         for vm_id, vm_obj in vms.iteritems():
             try:
@@ -245,8 +246,11 @@
                 # we want to make sure to have VM UUID logged
                 self._log.exception("while dispatching %s to VM '%s'",
                                     self._create, vm_id)
-            else:
+
+            try:
                 self._executor.dispatch(op, self._timeout)
+            except executor.TooManyTasks:
+                skipped.append(vm_id)
 
         if skipped:
             self._log.warning('could not run %s on %s',


-- 
To view, visit https://gerrit.ovirt.org/41657
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad2d186327f8607aaeb41ca132a9a8a0806869cf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list