Change in vdsm[master]: vm: event: simplify send_status_event

fromani at redhat.com fromani at redhat.com
Fri Jul 31 12:53:39 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: event: simplify send_status_event
......................................................................


Patch Set 16: Verified+1

Verification: installed Fedora on a freshly created VM, using patched VDSM.

Unsurprisingly, Events are still sent.

I happened to use ISCSI storage (block device/cow format), hence thin-provisioned volumes. A noteworthy side effect of this patch is that after each succesfull resize, the volume extension flow triggers VM.cont() which in turn sends one event.

We end up notifying multiple times the same status, like:

02c63f35-21ac-4956-9d0e-7486e530db01::DEBUG::2015-07-31 14:46:19,806::resourceManager::977::Storage.ResourceManager.Owner::(cancelAll) Owner.cancelAll requests {}
02c63f35-21ac-4956-9d0e-7486e530db01::DEBUG::2015-07-31 14:46:19,806::task::993::Storage.TaskManager.Task::(_decref) Task=`41a1ab5e-0300-4831-bbe4-4c624649db96`::ref 0 aborting False
02c63f35-21ac-4956-9d0e-7486e530db01::DEBUG::2015-07-31 14:46:19,806::vm::1064::virt.vm::(__verifyVolumeExtension) vmId=`5318c81c-c75a-4d16-b8bb-72ca6390ae07`::Verifying extension for volume e38ac0a1-d5ef-4c24-bef1-90f8ca60bcc4, requested size 2147483648, current size 2147483648
02c63f35-21ac-4956-9d0e-7486e530db01::INFO::2015-07-31 14:46:19,807::vm::4877::virt.vm::(_logGuestCpuStatus) vmId=`5318c81c-c75a-4d16-b8bb-72ca6390ae07`::CPU running: continue
02c63f35-21ac-4956-9d0e-7486e530db01::DEBUG::2015-07-31 14:46:19,807::__init__::206::jsonrpc.Notification::(emit) Sending event {"params": {"5318c81c-c75a-4d16-b8bb-72ca6390ae07": {"status": "Up"}, "notify_time": 4300226090}, "jsonrpc": "2.0", "method": "|virt|VM_status|5318c81c-c75a-4d16-b8bb-72ca6390ae07"}
--
4a3ce949-95a6-4a35-8bdc-a294890cffcc::DEBUG::2015-07-31 14:46:45,468::resourceManager::977::Storage.ResourceManager.Owner::(cancelAll) Owner.cancelAll requests {}
4a3ce949-95a6-4a35-8bdc-a294890cffcc::DEBUG::2015-07-31 14:46:45,468::task::993::Storage.TaskManager.Task::(_decref) Task=`a9d3f88f-ad3d-425e-854a-d83eea9ec8e4`::ref 0 aborting False
4a3ce949-95a6-4a35-8bdc-a294890cffcc::DEBUG::2015-07-31 14:46:45,468::vm::1064::virt.vm::(__verifyVolumeExtension) vmId=`5318c81c-c75a-4d16-b8bb-72ca6390ae07`::Verifying extension for volume e38ac0a1-d5ef-4c24-bef1-90f8ca60bcc4, requested size 3221225472, current size 3221225472
4a3ce949-95a6-4a35-8bdc-a294890cffcc::INFO::2015-07-31 14:46:45,469::vm::4877::virt.vm::(_logGuestCpuStatus) vmId=`5318c81c-c75a-4d16-b8bb-72ca6390ae07`::CPU running: continue
4a3ce949-95a6-4a35-8bdc-a294890cffcc::DEBUG::2015-07-31 14:46:45,469::__init__::206::jsonrpc.Notification::(emit) Sending event {"params": {"5318c81c-c75a-4d16-b8bb-72ca6390ae07": {"status": "Up"}, "notify_time": 4300251750}, "jsonrpc": "2.0", "method": "|virt|VM_status|5318c81c-c75a-4d16-b8bb-72ca6390ae07"}
--
dd4d9003-41f8-40b2-bf9c-979afcc6efb1::DEBUG::2015-07-31 14:47:26,240::resourceManager::977::Storage.ResourceManager.Owner::(cancelAll) Owner.cancelAll requests {}
dd4d9003-41f8-40b2-bf9c-979afcc6efb1::DEBUG::2015-07-31 14:47:26,240::task::993::Storage.TaskManager.Task::(_decref) Task=`cd948857-19d6-4979-8eb1-f81ce95d627d`::ref 0 aborting False
dd4d9003-41f8-40b2-bf9c-979afcc6efb1::DEBUG::2015-07-31 14:47:26,241::vm::1064::virt.vm::(__verifyVolumeExtension) vmId=`5318c81c-c75a-4d16-b8bb-72ca6390ae07`::Verifying extension for volume e38ac0a1-d5ef-4c24-bef1-90f8ca60bcc4, requested size 4294967296, current size 4294967296
dd4d9003-41f8-40b2-bf9c-979afcc6efb1::INFO::2015-07-31 14:47:26,242::vm::4877::virt.vm::(_logGuestCpuStatus) vmId=`5318c81c-c75a-4d16-b8bb-72ca6390ae07`::CPU running: continue
dd4d9003-41f8-40b2-bf9c-979afcc6efb1::DEBUG::2015-07-31 14:47:26,242::__init__::206::jsonrpc.Notification::(emit) Sending event {"params": {"5318c81c-c75a-4d16-b8bb-72ca6390ae07": {"status": "Up"}, "notify_time": 4300292520}, "jsonrpc": "2.0", "method": "|virt|VM_status|5318c81c-c75a-4d16-b8bb-72ca6390ae07"}
--
7e9e2880-27d7-45db-9233-c007ba7b3bf2::DEBUG::2015-07-31 14:47:55,415::resourceManager::977::Storage.ResourceManager.Owner::(cancelAll) Owner.cancelAll requests {}
7e9e2880-27d7-45db-9233-c007ba7b3bf2::DEBUG::2015-07-31 14:47:55,415::task::993::Storage.TaskManager.Task::(_decref) Task=`4603e87e-ee5f-4dc5-b9f9-bc0834571bb7`::ref 0 aborting False
7e9e2880-27d7-45db-9233-c007ba7b3bf2::DEBUG::2015-07-31 14:47:55,415::vm::1064::virt.vm::(__verifyVolumeExtension) vmId=`5318c81c-c75a-4d16-b8bb-72ca6390ae07`::Verifying extension for volume e38ac0a1-d5ef-4c24-bef1-90f8ca60bcc4, requested size 5368709120, current size 5368709120
7e9e2880-27d7-45db-9233-c007ba7b3bf2::INFO::2015-07-31 14:47:55,416::vm::4877::virt.vm::(_logGuestCpuStatus) vmId=`5318c81c-c75a-4d16-b8bb-72ca6390ae07`::CPU running: continue
7e9e2880-27d7-45db-9233-c007ba7b3bf2::DEBUG::2015-07-31 14:47:55,416::__init__::206::jsonrpc.Notification::(emit) Sending event {"params": {"5318c81c-c75a-4d16-b8bb-72ca6390ae07": {"status": "Up"}, "notify_time": 4300321700}, "jsonrpc": "2.0", "method": "|virt|VM_status|5318c81c-c75a-4d16-b8bb-72ca6390ae07"}


This is a confirmation that indeed the high water mark flow works as expected, but I'm not sure we want to send this repeated Event.

-- 
To view, visit https://gerrit.ovirt.org/43414
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3013d1e2a1a2f6e8c325adb37c0019fab0c7a4f6
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list