Change in vdsm[master]: register: use node name and fqdn when needed

danken at redhat.com danken at redhat.com
Fri Jul 31 12:02:39 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: register: use node name and fqdn when needed
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/44221/1/lib/vdsm/tool/register.py
File lib/vdsm/tool/register.py:

Line 147: 
Line 148:         if self.node_name is not None:
Line 149:             ureg += "&name={name}".format(name=self.node_name)
Line 150: 
Line 151:         if self.node_fqdn is not None:
> I believe the caller of vdsm-tool register will decide if it should use --n
it does make sense, but doesn't it mean that on Engine the end user would not see a human-readable name next to the IP address?
Line 152:             ureg += "&address={fqdn}".format(fqdn=self.node_fqdn)
Line 153: 
Line 154:         self.url_reg = "{e}{u}".format(e=self.engine_url, u=ureg)
Line 155: 


-- 
To view, visit https://gerrit.ovirt.org/44221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91c834e10cade4878791be43201ab0966bf251b4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list