Change in vdsm[master]: register: remove legacy code
danken at redhat.com
danken at redhat.com
Fri Jul 31 10:55:04 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: register: remove legacy code
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
nit about log message and docstring.
note that I've fixed the commit message.
https://gerrit.ovirt.org/#/c/44219/3/lib/vdsm/tool/register.py
File lib/vdsm/tool/register.py:
Line 126: Initial communication with Engine to validate
Line 127: the registration as a service.
Line 128: """
Line 129:
Line 130: self.logger.info("Starting registration as a service...")
service? this is not a service, but a command-line tool.
I don't understand this message :-(
Line 131:
Line 132: ucmd = "/ovirt-engine/services/host-register?version=1&command="
Line 133: __GET_VERSION = "https://{e}{u}{c}".format(e=self.engine_fqdn,
Line 134: u=ucmd,
--
To view, visit https://gerrit.ovirt.org/44219
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c0bf6c8879538faa5ddc1d3eb92555aba272c22
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list