Change in vdsm[master]: tcTests: Fix problem of left over bridges

nsoffer at redhat.com nsoffer at redhat.com
Fri Jul 31 10:50:53 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: tcTests: Fix problem of left over bridges
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/44028/2/tests/tcTests.py
File tests/tcTests.py:

Line 105: 
Line 106:     def delDevice(self):
Line 107:         try:
Line 108:             self._ifDown()
Line 109:             check_call([EXT_BRCTL, 'delbr', self.devName])
> I agree, but I will let the review open until we have a real solution, beca
I think that this topic solve most of the issues:
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:tests-isolation
Line 110:         except ExecError:
Line 111:             # Sometimes the bridge is not shut down, although ip reports so.
Line 112:             # Just retrying the shutdown and the removal once is enough to
Line 113:             # work around that.


-- 
To view, visit https://gerrit.ovirt.org/44028
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd0d8f20283fdf80977bd1f78f5b2ac62f7e83c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list