Change in vdsm[master]: nettestlib: Remove unneeded hack for improving randomness

nsoffer at redhat.com nsoffer at redhat.com
Thu Jul 30 23:29:00 UTC 2015


Nir Soffer has uploaded a new change for review.

Change subject: nettestlib: Remove unneeded hack for improving randomness
......................................................................

nettestlib: Remove unneeded hack for improving randomness

Python seed the random number generator from os.urandom() on startup, so
different processes do not use the same seed, and produce different
sequences of pseudo random numbers by default.

Change-Id: I631ec8572bb6a69ee086011d67daf7ed000d718b
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M tests/nettestlib.py
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/44216/1

diff --git a/tests/nettestlib.py b/tests/nettestlib.py
index 44a831d..ab7a8d5 100644
--- a/tests/nettestlib.py
+++ b/tests/nettestlib.py
@@ -21,7 +21,6 @@
 import fcntl
 import os
 import platform
-import random
 import signal
 import struct
 from multiprocessing import Process
@@ -144,10 +143,6 @@
 
 
 def checkDependencies():
-
-    # hack to avoid name collision in concurrently-running mock-based tests
-    random.jumpahead(os.getpid())
-
     dev = Bridge()
     try:
         dev.addDevice()


-- 
To view, visit https://gerrit.ovirt.org/44216
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I631ec8572bb6a69ee086011d67daf7ed000d718b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list