Change in vdsm[master]: stomp: make sure to send error message when no subscription

nsoffer at redhat.com nsoffer at redhat.com
Thu Jul 30 15:12:03 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: stomp: make sure to send error message when no subscription
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/43724/2/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 196: 
Line 197:             if len(subs) == 0:
Line 198:                 self._send_error("Subscription not available",
Line 199:                                  dispatcher.connection)
Line 200:                 return
How do we have empty subs list? Maybe a better fix would be to never hold an empty subs list?

Add the list when the first subscription requested, remove the list when the last one is removed.
Line 201: 
Line 202:             for subscription in subs:
Line 203:                 headers = utils.picklecopy(frame.headers)
Line 204:                 headers = {stomp.Headers.SUBSCRIPTION: subscription.id}


-- 
To view, visit https://gerrit.ovirt.org/43724
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1880caa04bb5e506679da046a58491d3e29e10e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list