Change in vdsm[master]: jsonrpc: ignore unknown message id

fromani at redhat.com fromani at redhat.com
Thu Jul 30 14:44:06 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: jsonrpc: ignore unknown message id
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/43746/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 295:     def requestDone(self, response):
Line 296:         try:
Line 297:             del self._requests[response.id]
Line 298:         except KeyError:
Line 299:             # ignore when request had no id
the comment and the code disagree here, because here you are ignoring responses with id not present in the _requests dict.

Better to either fix the comment describing when this happens
Line 300:             pass
Line 301:         self.addResponse(response)
Line 302:         self.sendReply()
Line 303: 


-- 
To view, visit https://gerrit.ovirt.org/43746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide306f44c8c42d6661932698307efa4ce163e90e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list