Change in vdsm[master]: hostdev: don't send address type for source address

fromani at redhat.com fromani at redhat.com
Thu Jul 30 14:35:08 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: hostdev: don't send address type for source address
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

patch itself seems OK, but maybe better file libvirt bug. -1 for visibility.

https://gerrit.ovirt.org/#/c/44177/1//COMMIT_MSG
Commit Message:

Line 7: hostdev: don't send address type for source address
Line 8: 
Line 9: Libvirt (domain_conf.c) does not expect the type for the host address,
Line 10: and drops it if we send it. This causes USB address matching to fail
Line 11: when parsing dom XML.
Maybe better file a bug against libvirt? The behaviour seems surprising enough to deserve that.
Line 12: 
Line 13: Same applies for SR-IOV, the example in libvirt documentation states
Line 14: the type but it is again dropped.
Line 15: 


-- 
To view, visit https://gerrit.ovirt.org/44177
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12592dd53f8af25fe8e1312b810e6b6f48411083
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list