Change in vdsm[master]: vmstats: do not report empty balloonInfo

danken at redhat.com danken at redhat.com
Thu Jul 30 09:49:04 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vmstats: do not report empty balloonInfo
......................................................................


vmstats: do not report empty balloonInfo

Do not report empty value for 'balloonInfo'
stats, much like we do for disks and networks

In general, we should avoid to report empty values
if the emptiness carries no meaning (noteworthy counterexample:
vmJobs for live merge).

Change-Id: I146e1f476434f023281f475ffaaa808f4cdf862b
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/43539
Reviewed-by: Martin Polednik <mpolednik at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/virt/vmstats.py
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/43539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I146e1f476434f023281f475ffaaa808f4cdf862b
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list