Change in vdsm[master]: vm: make up pauseCode if libvirt is omitting it

danken at redhat.com danken at redhat.com
Thu Jul 30 09:05:51 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: make up pauseCode if libvirt is omitting it
......................................................................


vm: make up pauseCode if libvirt is omitting it

When VDSM receives one IOError notification from libvirt,
it can override the VM pauseCode. The same pauseCode will
be reported to Engine through Events or through the
VM.getStats() API.

For historical reasons, libvirt reliably reports only the
'enospc' reason. In the other cases, the reason is an
empty string, and this resets the pauseCode to empty string.

Engine is not (anymore) expecting that.
To make Engine happy(er), and to improve the quality of data
VDSM reports in general, it is safe to report EOTHER
if the pauseCode is not given onIOError.

This patch does that.

Change-Id: I0bde0561cae20971effcf01c8a57159edcc4c42e
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44115
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Continuous-Integration: Jenkins CI
---
M vdsm/virt/vm.py
1 file changed, 12 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/44115
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0bde0561cae20971effcf01c8a57159edcc4c42e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list