Change in vdsm[master]: tests: Fix expandPermutations use with Mixins

danken at redhat.com danken at redhat.com
Wed Jul 29 18:50:16 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Fix expandPermutations use with Mixins
......................................................................


tests: Fix expandPermutations use with Mixins

When using the expandPermutations decorator on Mixin classes or in
classes which will be inherited from it is important to remove the
PERMUTATION_ATTR from functions that have been processed.  Otherwise we
will attempt to expand already expanded permutations when subclassing or
mixing this class.

Change-Id: Idcc0805ce2e77bfa4987142ccfd76b4003222471
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44151
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/testlib.py
M tests/testlibTests.py
2 files changed, 23 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Adam Litke: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/44151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idcc0805ce2e77bfa4987142ccfd76b4003222471
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list