Change in vdsm[master]: tests: Use more random interface names

danken at redhat.com danken at redhat.com
Wed Jul 29 18:49:51 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Use more random interface names
......................................................................


tests: Use more random interface names

Shorten the default prefix, allowing longer random suffix, and generate
the name using utils.random_iface_name(), using the all 15 characters.

One test was depending on shorter interface name, appending "A" to the
existing device name. Using now "__nosuchiface__" which communicate the
intent of the test better.

Change-Id: Iffcabc7992e787d1e2cf38ce4ad2164cc80c646e
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44111
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/tcTests.py
1 file changed, 4 insertions(+), 8 deletions(-)

Approvals:
  Nir Soffer: Verified
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/44111
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iffcabc7992e787d1e2cf38ce4ad2164cc80c646e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list