Change in vdsm[master]: virt: enable libgfapi

nsoffer at redhat.com nsoffer at redhat.com
Wed Jul 29 13:40:41 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: virt: enable libgfapi
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.ovirt.org/#/c/44061/5/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 322:                 if drive.get('diskType') == DISK_TYPE.NETWORK:
Line 323:                     volinfo = res ['info']
Line 324:                     volPath = volinfo['path']
Line 325:                     drive['protocol'] = volinfo['protocol']
Line 326:                     if drive.get('hosts') is None:
No need for this check, we are not expecting hosts from engine.
Line 327:                         """
Line 328:                         currently, single host is provided due to this bug:
Line 329:                         https://bugzilla.redhat.com/1247521
Line 330:                         """


Line 326:                     if drive.get('hosts') is None:
Line 327:                         """
Line 328:                         currently, single host is provided due to this bug:
Line 329:                         https://bugzilla.redhat.com/1247521
Line 330:                         """
This is not a comment, this is a docstring, which belongs only to modules, classes or functions. Comment should use # prefix.
Line 331:                         drive['hosts'] = [volinfo['hosts'][0]]
Line 332: 
Line 333:             # GUID drive format
Line 334:             elif "GUID" in drive:


https://gerrit.ovirt.org/#/c/44061/5/vdsm/storage/glusterVolume.py
File vdsm/storage/glusterVolume.py:

Line 50:         imgFileRelPath = "/".join(imgFilePath_list[-4:])
Line 51: 
Line 52:         glusterPath = volname + '/' + imgFileRelPath
Line 53: 
Line 54:         hosts = [dict(name=brick.split(":")[0],
split only once - split(";", 1)
Line 55:                       port=volPort,
Line 56:                       transport=volTrans)
Line 57:                  for brick in volInfo[volname]['bricks']]
Line 58: 


-- 
To view, visit https://gerrit.ovirt.org/44061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list