Change in vdsm[master]: net: always persist owned ifcfg files on ovirt node

ibarkan at redhat.com ibarkan at redhat.com
Wed Jul 29 08:35:06 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: net: always persist owned ifcfg files on ovirt node
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/44112/1/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 478
Line 479
Line 480
Line 481
Line 482
> I do not think that this is correct. If a file is pre-persisted, it means t
I strive to make ovirt-node behave like rhel under /etc/sysconfig/network-scripts. why un-persist just to persist again later in setSafe()? Assuming a user screws up an ifcfg, the restoration can fix it for him (exactly like in rhel) if he would like (reboot or run vdsm-tool restore-nets --force)
Also, I would like to make this whole directory persistent but I am not sure if this should be done during vdsm service start or in ovirt-node code itself.


https://gerrit.ovirt.org/#/c/44112/1/vdsm/vdsm-store-net-config.in
File vdsm/vdsm-store-net-config.in:

Line 36:     # /etc/sysconfig as "safe".
Line 37:     rm -rf "$NET_CONF_BACK_DIR"/*
Line 38: }
Line 39: 
Line 40: node_persist_owned_ifcfgs() {
> this could be right, but please look up in the history. I think we use to h
unified_node_persist was added in 7e7cceb38e962b5c490d4a24e9f4ffa4a418c243 (10/2013) and wasn't changed since
Line 41:     for f in $(find "$NET_CONF_DIR" -type f); do
Line 42:         if grep -q "# Generated by VDSM version" $f; then
Line 43:             ovirt_store_config "$f"
Line 44:         fi


-- 
To view, visit https://gerrit.ovirt.org/44112
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc717b86194a32c050d346e235a5c35fd318e1ff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list