Change in vdsm[master]: tests: Fix error handling when checking dependencies

danken at redhat.com danken at redhat.com
Wed Jul 29 07:37:40 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Fix error handling when checking dependencies
......................................................................


tests: Fix error handling when checking dependencies

We used to hide *all* exceptions and skip the tests with possible bogus
message.

When trying brctl, we skip the test only if we cannot run it, since this
is the only error that can cause by missing bridge-utils. Any other
error should fail the tests.

When trying tc, we show the failure in the error message.

Also removed pointless code opening and closing /dev/null, which should
have been dropped in commit 61fff86c.

Change-Id: I180ba6449009dc986d2df58958039e2324d2191f
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44110
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/tcTests.py
1 file changed, 9 insertions(+), 8 deletions(-)

Approvals:
  Nir Soffer: Verified
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/44110
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I180ba6449009dc986d2df58958039e2324d2191f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list