Change in vdsm[master]: tests: Use more random interface names
ibarkan at redhat.com
ibarkan at redhat.com
Wed Jul 29 05:10:53 UTC 2015
Ido Barkan has posted comments on this change.
Change subject: tests: Use more random interface names
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44111/3/tests/tcTests.py
File tests/tcTests.py:
Line 69:
Line 70: def __init__(self, prefix='vdsm-'):
Line 71: self.devName = self._generateRandomName(prefix)
Line 72:
Line 73: def _generateRandomName(self, prefix):
you can just replace it with utils.random_iface_name
Line 74: char_set = string.ascii_letters + string.digits + "_-"
Line 75: rand_len = self.MAX_NAME - len(prefix)
Line 76: return prefix + ''.join(random.choice(char_set)
Line 77: for _ in range(rand_len))
--
To view, visit https://gerrit.ovirt.org/44111
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffcabc7992e787d1e2cf38ce4ad2164cc80c646e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list