Change in vdsm[master]: mount: Implement __ne__

danken at redhat.com danken at redhat.com
Tue Jul 28 23:34:53 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: mount: Implement __ne__
......................................................................


mount: Implement __ne__

"""
There are no implied relationships among the comparison operators. The
truth of x==y does not imply that x!=y is false. Accordingly, when
defining __eq__(), one should also define __ne__() so that the operators
will behave as expected.
"""
See https://docs.python.org/2/reference/datamodel.html#object.__eq__

This fixes the test_ne broken test.

Change-Id: I9b08fe7ee472c3582ee9816988db66e92c2542ea
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/43977
Continuous-Integration: Jenkins CI
Reviewed-by: Freddy Rolland <frolland at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/mountTests.py
M vdsm/storage/mount.py
2 files changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/43977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b08fe7ee472c3582ee9816988db66e92c2542ea
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list