Change in vdsm[master]: tests: Add RWLock tests

nsoffer at redhat.com nsoffer at redhat.com
Mon Jul 27 12:01:46 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: tests: Add RWLock tests
......................................................................


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/42907/13/tests/rwlock_test.py
File tests/rwlock_test.py:

Line 148:                 self.assertFalse(reader.acquired.wait(1))
Line 149:             # Writer should get in before the reader
Line 150:             self.assertTrue(writer.acquired.wait(1))
Line 151:             writer.done.set()
Line 152:             self.assertTrue(reader.acquired.wait(1))
> theoretically only. if something would swallow exceptions in lock.shared __
I think we are safe assuming that lock.shared is implemented correctly.
Line 153:         finally:
Line 154:             for t in threads:
Line 155:                 t.stop()
Line 156: 


-- 
To view, visit https://gerrit.ovirt.org/42907
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If404f0e8c68fcdb2f7643bdd6d5c1f97f230a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list