Change in vdsm[master]: tests: Add RWLock tests

nsoffer at redhat.com nsoffer at redhat.com
Mon Jul 27 10:46:31 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: tests: Add RWLock tests
......................................................................


Patch Set 13:

(4 comments)

https://gerrit.ovirt.org/#/c/42907/13/tests/rwlock_test.py
File tests/rwlock_test.py:

Line 48:             for t in readers:
Line 49:                 t.stop()
Line 50: 
Line 51:     @slowtest
Line 52:     def test_wakeup_blocked_writer(self):
> wake_up
ok
Line 53:         lock = RWLock()
Line 54:         reader = LockingThread(lock.shared)
Line 55:         with utils.running(reader):
Line 56:             if not reader.acquired.wait(2):


Line 63:                 reader.done.set()
Line 64:                 self.assertTrue(writer.acquired.wait(2))
Line 65: 
Line 66:     @slowtest
Line 67:     def test_wakeup_blocked_reader(self):
> wake_up
ok
Line 68:         lock = RWLock()
Line 69:         writer = LockingThread(lock.exclusive)
Line 70:         with utils.running(writer):
Line 71:             if not writer.acquired.wait(2):


Line 78:                 writer.done.set()
Line 79:                 self.assertTrue(reader.acquired.wait(2))
Line 80: 
Line 81:     @slowtest
Line 82:     def test_wakeup_all_blocked_readers(self):
> wake_up
ok
Line 83:         lock = RWLock()
Line 84:         readers = 10
Line 85:         ready = Barrier(readers + 1)
Line 86:         done = Barrier(readers + 1)


Line 148:                 self.assertFalse(reader.acquired.wait(1))
Line 149:             # Writer should get in before the reader
Line 150:             self.assertTrue(writer.acquired.wait(1))
Line 151:             writer.done.set()
Line 152:             self.assertTrue(reader.acquired.wait(1))
> reader might be referenced before assignment
Can you explain how?
Line 153:         finally:
Line 154:             for t in threads:
Line 155:                 t.stop()
Line 156: 


-- 
To view, visit https://gerrit.ovirt.org/42907
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If404f0e8c68fcdb2f7643bdd6d5c1f97f230a227
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list