Change in vdsm[master]: fc-connect-server: Add FcpConnection class

frolland at redhat.com frolland at redhat.com
Mon Jul 27 07:03:40 UTC 2015


Hello Fred Rolland,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/44010

to review the following change.

Change subject: fc-connect-server: Add FcpConnection class
......................................................................

fc-connect-server: Add FcpConnection class

Add FcpConnection class in storageServer.py.
All methods except eq and hash are not implemented.

This class permit the engine to call connectStorageServer on
FC storage domain so that sdCache.refreshStorage and prefetchDomains
will be performed on FC SD also.

Change-Id: I0a2c937cb997244df7910fc7cfcae11b088d3cdb
Bug-Url: https://bugzilla.redhat.com/1242200
Signed-off-by: Fred Rolland <frolland at redhat.com>
---
M vdsm/storage/storageServer.py
1 file changed, 23 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/44010/1

diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index e71b88c..6444d2a 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -69,6 +69,8 @@
                                      "export, retrans, timeout, version, "
                                      "extraOptions")
 
+FcpConnectionParameters = namedtuple("FcpConnectionParameters", "type")
+
 ConnectionInfo = namedtuple("ConnectionInfo", "type, params")
 
 
@@ -548,6 +550,26 @@
         return hsh
 
 
+class FcpConnection(object):
+    def __init__(self, type):
+        pass
+
+    def connect(self):
+        pass
+
+    def disconnect(self):
+        pass
+
+    def isConnected(self):
+        pass
+
+    def __eq__(self, other):
+        return self.__class__ == other.__class
+
+    def __hash__(self):
+        return hash(type(self))
+
+
 class LocalDirectoryConnection(object):
     @property
     def path(self):
@@ -700,6 +722,7 @@
         "glusterfs": GlusterFSConnection,
         "iscsi": IscsiConnection,
         "localfs": LocalDirectoryConnection,
+        "fcp": FcpConnection,
     }
 
     @classmethod


-- 
To view, visit https://gerrit.ovirt.org/44010
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a2c937cb997244df7910fc7cfcae11b088d3cdb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>


More information about the vdsm-patches mailing list