Change in vdsm[master]: net: fix testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconf...

ibarkan at redhat.com ibarkan at redhat.com
Mon Jul 27 05:36:07 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: net: fix testSetupNetworksDeletesTheBridgeOnlyWhenItIsReconfigured
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/43995/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1007:         def add_tap_to_bridge():
Line 1008:             tap = Tap(prefix='vnet')
Line 1009:             tap.addDevice()
Line 1010:             rc, _, _ = execCmd([EXT_BRCTL, 'addif', NETWORK_NAME, tap.devName])
Line 1011:             self.assertEquals(rc, 0, 'brctl addif failed: rc=%s' % (rc,))
> delDevice on exception
Done
Line 1012:             return tap
Line 1013: 
Line 1014:         STANDARD, BIG = 1500, 2000
Line 1015:         with dummyIf(2) as nics:


Line 1028:             status, msg = self.setupNetworks(second_net, {}, NOCHK)
Line 1029:             self.assertEquals(status, SUCCESS, msg)
Line 1030:             second_bridge_index = get_bridge_index()
Line 1031:             self.assertEquals(bridge_index, second_bridge_index)
Line 1032:             tap.delDevice()
> This should go into a finally clause, started right after tap was created.
Done
Line 1033:             # the kernel bridge driver automatically updates the bridge to the
Line 1034:             # new minimum MTU of all of its connected interfaces
Line 1035:             self.assertMtu(BIG, NETWORK_NAME, second)
Line 1036: 


-- 
To view, visit https://gerrit.ovirt.org/43995
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52d0c04ffd3c047c1e66cec3d1a9646717d90a21
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list