Change in vdsm[master]: tests: Create storagetestlib module

nsoffer at redhat.com nsoffer at redhat.com
Sun Jul 26 16:42:54 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: tests: Create storagetestlib module
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

Looks fine expect the default number of pv in a vg.

https://gerrit.ovirt.org/#/c/43547/4/tests/storagetestlib.py
File tests/storagetestlib.py:

Line 24: 
Line 25: from storage import sd, blockSD, fileSD
Line 26: 
Line 27: 
Line 28: NR_PVS = 5       # The number of fake PVs we use to make a fake VG by default
I would use 2 or 3 pvs to keep the tests results simpler. 2 pvs should be enough to simulate a vg with multiple pvs, no?

Creating 5 pvs make it much harder to debug failure in the tests, trying to peek into self.pvmd with 15 items is harder than one with 6 items.
Line 29: MDSIZE = 524288  # The size (in bytes) of fake metadata files
Line 30: 
Line 31: 
Line 32: class FakeMetadata(dict):


-- 
To view, visit https://gerrit.ovirt.org/43547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I713e19473b45bc05da5a1c888a034306144228c5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list