Change in vdsm[master]: storage: simplify hasVolumeLeases
nsoffer at redhat.com
nsoffer at redhat.com
Sun Jul 26 16:35:04 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: storage: simplify hasVolumeLeases
......................................................................
Patch Set 4: Code-Review-1
(3 comments)
Missing self and the trivial unittest that should fail with current code.
https://gerrit.ovirt.org/#/c/43548/4/vdsm/storage/clusterlock.py
File vdsm/storage/clusterlock.py:
Line 89: self.setParams(lockRenewalIntervalSec, leaseTimeSec, leaseFailRetry,
Line 90: ioOpTimeoutSec)
Line 91:
Line 92: @property
Line 93: def supports_volume_leases():
Missing self
Line 94: return False
Line 95:
Line 96: def initLock(self):
Line 97: lockUtil = constants.EXT_SAFELEASE
Line 208: self._leasesPath = leasesPath
Line 209: self._sanlockfd = None
Line 210:
Line 211: @property
Line 212: def supports_volume_leases():
self
Line 213: return True
Line 214:
Line 215: def initLock(self):
Line 216: initSANLock(self._sdUUID, self._idsPath, self._leasesPath)
Line 370: self._idsPath = idsPath
Line 371: self._leasesPath = leasesPath
Line 372:
Line 373: @property
Line 374: def supports_volume_leases():
self
Line 375: return True
Line 376:
Line 377: def initLock(self):
Line 378: # The LocalLock initialization is based on SANLock to maintain on-disk
--
To view, visit https://gerrit.ovirt.org/43548
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0c1cf341e7d028b5d4e30a27e9a045b43470e4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list