Change in vdsm[master]: xmlrpc: Fix the inheritance mess

danken at redhat.com danken at redhat.com
Thu Jul 23 16:22:05 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: xmlrpc: Fix the inheritance mess
......................................................................


xmlrpc: Fix the inheritance mess

Now that the xmlrpc server is not listening for connections, there is no
need to inherit from SimpleXMLRPCServer and its many super classes. The
xmlprc server is a very simple object that takes connected sockets from
a queue and starts a request handler for each socket in a new thread.
Most of the logic in the server is in the request handler class.

This patch implements this simple object, based on code from
SocketServer, BaseHTTPServer, and SimpleXMLRPCServer. This makes it easy
to understand and maintain, and remove dependencies on the fragile
Python server class hierarchy.

Change-Id: Ia912a465706b49f3f9146b2a74311fdd5a50f85e
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/43792
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/xmlrpc.py
1 file changed, 50 insertions(+), 51 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/43792
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia912a465706b49f3f9146b2a74311fdd5a50f85e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list