Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
nsoffer at redhat.com
nsoffer at redhat.com
Thu Jul 23 12:22:39 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: net: backport cmdutils.systemd_run
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/43852/3/vdsm/sudoers.vdsm.in
File vdsm/sudoers.vdsm.in:
Line 32: @MULTIPATH_PATH@, \
Line 33: @SETSID_PATH@ @IONICE_PATH@ -c ? -n ? @SU_PATH@ vdsm -s /bin/sh -c /usr/libexec/vdsm/spmprotect.sh*, \
Line 34: @SERVICE_PATH@ vdsmd *, \
Line 35: @REBOOT_PATH@ -f, \
Line 36: @SYSTEMD_RUN_PATH@
> this is a security breach that should be fixed on master, as it allows vdsm
Fixed in https://gerrit.ovirt.org/43937
Line 37:
Line 38: vdsm ALL=(ALL) NOPASSWD: VDSM_LIFECYCLE, VDSM_STORAGE
Line 39: Defaults:vdsm !requiretty
--
To view, visit https://gerrit.ovirt.org/43852
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list