Change in vdsm[ovirt-3.5]: hooks: introduce before/after_get_stats hook points

ibarkan at redhat.com ibarkan at redhat.com
Thu Jul 23 07:01:00 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: hooks: introduce before/after_get_stats hook points
......................................................................


Patch Set 1:

(1 comment)

nit. -1 just for control.

https://gerrit.ovirt.org/#/c/43274/1/vdsm/API.py
File vdsm/API.py:

Line 1302:         def _readSwapTotalFree():
Line 1303:             meminfo = utils.readMemInfo()
Line 1304:             return meminfo['SwapTotal'] / 1024, meminfo['SwapFree'] / 1024
Line 1305: 
Line 1306:         hooks.before_get_stats()
it might be useful to start with:
stats = hooks.before_get_stats() or {}

although I admit I can't come up with a good example right now.
Line 1307:         stats = {}
Line 1308:         decStats = self._cif._hostStats.get()
Line 1309: 
Line 1310:         if self._cif.irs:


-- 
To view, visit https://gerrit.ovirt.org/43274
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1ff93837abb73f88ececc7571115645b95486cf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list