Change in vdsm[master]: gluster: fix xfs filesystem is created with wrong inode size

rnachimu at redhat.com rnachimu at redhat.com
Thu Jul 23 06:49:54 UTC 2015


Ramesh N has posted comments on this change.

Change subject: gluster: fix xfs filesystem is created with wrong inode size
......................................................................


Patch Set 1:

(1 comment)

May be its better to have a small write up in the program itself to explain what exactly we are doing when we say createBrick. Currently its scattered across multiple functions and its not very easy to understand and review.

Also if we have a write up we can easily ask the QE/Performance team to verify.

https://gerrit.ovirt.org/#/c/43847/1/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 314: "-d", "sw=%s,su=%sk" % (count, raidParams.get('stripeSize')),
For RAID 10 and JBOD, the -d su=<>,sw=<> option can be omitted. By default, XFS will use the thin-p chunk size and other parameters to make layout decisions. More at https://access.redhat.com/documentation/en-US/Red_Hat_Storage/3/html/Administration_Guide/Brick_Configuration.html.


-- 
To view, visit https://gerrit.ovirt.org/43847
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3f350d2f79172705a93a9d69fe1b7b78867861e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list