Change in vdsm[master]: network: add 'default_route' parameter to DhcpClient

danken at redhat.com danken at redhat.com
Wed Jul 22 14:48:51 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: network: add 'default_route' parameter to DhcpClient
......................................................................


Patch Set 2: Code-Review-1

sounds great!

However, do initscripts use -e DEFROUTE=no ? could you mention how ifcfg works fine?

Also, I think that you should expose the new arg on runDhclient, and pass defaultRoute into it.

-- 
To view, visit https://gerrit.ovirt.org/43900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4c3a7c5598f2a7b10670415714d980113bc72ae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list